1 Topic by lordjoe (edited by lordjoe 2012-09-01 16:12:42)

  • Registered: 2009-03-16

Topic: coverart.py & amazon asin (possible fix)

In a past thread voiceinsideyou explains why ASIN is not ideal for cover art (http://forums.musicbrainz.org/viewtopic.php?id=3334). That said, I think coverart.py is currently completely broken with respect to ASIN.
edit: *** below not useful, I needed to enable Options, Metadata, "use release relationships"

I hacked it to work again (standard disclaimers: "works for me", "might eat your data", etc...). I did not try to investigate when this change happened or if I've fixed it in the correct manner. The basic idea is that we can get access to the asin directly from the top level release metadata instead of searching for relationship URLs (which it appears are not in the same place as before).

new coverart.py: http://pastebin.com/nB7HrDGa
diff: http://pastebin.com/AkNFbXC2

I'm using Picard 1.0 (never thought I would see the day 1.0 is released! does this mean the plugin api will be stable?)

HTH

  • Registered: 2012-02-16

Re: coverart.py & amazon asin (possible fix)

lordjoe wrote:

In a past thread voiceinsideyou explains why ASIN is not ideal for cover art (http://forums.musicbrainz.org/viewtopic.php?id=3334). That said, I think coverart.py is currently completely broken with respect to ASIN.

Could you describe in detail what's wrong? I'm currently working on integrating the plugin into Picard itself and haven't found anything weird regarding the way it deals with Amazon coverart (except for Amazon doing stupid stuff like exposing 1x1px images).

  • Registered: 2009-03-16

Re: coverart.py & amazon asin (possible fix)

OK, I found it! I needed "use release relationships" enabled in Options, Metadata. Makes sense now in retrospect. I'm not sure why that option was turned off (probably me being stupid since it's been months since I last used Picard).

This option enables requesting "artist-rels+release-rels+url-rels+recording-rels+work-rels" from the release.

Here is my thought process below if anyone is still interested...

My test release: http://musicbrainz.org/release/21695712 … b511d13452
release metadata (from wireshark): http://musicbrainz.org/ws/2/release/216 … bels+isrcs
The "release" parameter from register_album_metadata_processor is from the metadata url above (picard/album.py:72)

There simply is no 'relation_list' metadata, so coverart.py never finds anything. There is, however, an 'asin' entry, which is what I think I used instead.